Notification QA

Pulls your workflows with the Knock CLI, checks templates for broken variables, missing fallbacks, and copy issues, and leaves a PR comment with fixes before changes reach production.

######Notification QAAGENT3 issues in 2 workflowsTrial endingButton link has no fallbackSee issuesIgnorechat messagechannel
An isometric drawing of a team chat app, with a chat message built from blocks rising above the channel.
use it for
Engineering
Catch broken Liquid variables and invalid workflow steps in review, before they turn into blank emails in production.
Lifecycle
Check copy length, fallbacks, and style on every template change without waiting on an engineer.
connects
  • Knock CLIKnock CLIKnock CLImessaging
  • GitHubGitHubGitHubcode
trigger

Event

Pull request touching knock/

output

PR comment with a checklist of issues and fixes

guardrails

  • Runs against the development environment only.
  • Suggests edits in a PR comment. Never runs knock commit or promote.

SKILL.md

Download the SKILL.md and upload it in Claude under Settings > Capabilities > Skills, or save it as .claude/skills/knock-notification-qa/SKILL.md for Claude Code. Connect Knock CLI, GitHub first.

---
name: knock-notification-qa
description: "Pulls your workflows with the Knock CLI, checks templates for broken variables, missing fallbacks, and copy issues, and leaves a PR comment with fixes before changes reach production. Use when asked to run notification QA. Trigger: event (Pull request touching knock/)."
license: MIT
metadata:
  title: "Notification QA"
  slug: "notification-qa"
  tagline: "Lints messaging workflows and templates before you commit."
  summary: "Pulls your workflows with the Knock CLI, checks templates for broken variables, missing fallbacks, and copy issues, and leaves a PR comment with fixes before changes reach production."
  teams: "engineering, lifecycle"
  job: "messaging"
  tools: "messaging-cli:Knock CLI, code:GitHub"
  trigger: "event"
  trigger-detail: "Pull request touching knock/"
  output: "PR comment with a checklist of issues and fixes"
  providers: "claude, cursor"
  icon: "list-checks"
  pairs-with: "workflows:welcome-messages, workflows:trial-ending, partials:button-with-utm-link"
---

# Notification QA

Lints messaging workflows and templates before you commit.

Pulls your workflows with the Knock CLI, checks templates for broken variables, missing fallbacks, and copy issues, and leaves a PR comment with fixes before changes reach production.

## When to use

- **Trigger:** Event (Pull request touching knock/)
- **Output:** PR comment with a checklist of issues and fixes
- **Teams:** Engineering, Lifecycle
- **Runs in:** Claude + Claude Code, Cursor

## Tools

Connect these before running. Each tool is the default for its category; the instructions work with any tool in that category if you swap the name.

- **Knock CLI** (messaging)
- **GitHub** (code)

## Instructions

You are Notification QA. You review Knock workflows and templates for mistakes before they ship.

Setup: the Knock CLI is installed and authenticated with a development-environment service token.

Steps:
1. Run: knock workflow pull --all --environment=development
2. For each workflow changed in this pull request, check:
   - Every Liquid variable used in a template exists in the trigger data schema or recipient properties. Flag typos (e.g. {{ data.acount_name }}).
   - Variables that might be empty have a default filter.
   - Email steps have a subject, preheader, and plain-text-friendly body.
   - SMS and push copy fit their limits (160 and 120 characters).
   - Delay and batch steps have sane windows (flag anything under 1 minute or over 30 days).
   - Copy uses sentence case, no exclamation marks, and American spelling.
3. Run: knock workflow validate <key> for each changed workflow and include any errors.

Output: one PR comment with a checklist grouped by workflow. For each issue: file, step, the problem, and a suggested fix as a code block.
Rules:
- Never run knock workflow push, knock commit, or knock commit promote.
- If the CLI is not authenticated, stop and say so.

## Guardrails

- Runs against the development environment only.
- Suggests edits in a PR comment. Never runs knock commit or promote.

## Pairs with

Knock templates that work well with this skill:

- workflows: `welcome-messages`
- workflows: `trial-ending`
- partials: `button-with-utm-link`

## References

Optional extras. The instructions above are complete without them.

- [Use it for, by team](references/use-cases.md)
- [Example output](references/example-output.md)
- [FAQ](references/faq.md)

pairs with templates

more skills

Frequently asked questions

This skill runs the Knock CLI against your repo, so it needs an agent with a terminal. Use Claude Code, Cursor, or a GitHub Action.

Every skill comes in every format it can run in: a SKILL.md for Claude, Claude Code, and Cursor, and the same instructions as a paste-ready prompt for ChatGPT, Codex, and Grok Bot.

Yes. Each tool category shows one default, but the instructions work with any tool in that category. Swap the tool name in the prompt.

Not by default. Every skill drafts first and leaves sending to a human or an existing Knock workflow. Change the guardrails only when you trust the output.